Skip to content

UI updates for global search #41781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 3 commits into from
Nov 29, 2023
Merged

UI updates for global search #41781

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fe7ba5
Improve accesibility for search tags/chips
nfebe Nov 27, 2023
1c5ceaf
Unbold user names in SearchableList
nfebe Nov 27, 2023
1534ba0
Fix date filter wording & improve search feedback
nfebe Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Improve accesibility for search tags/chips 
- Use stand font of filter tags/chips
- No bold
- Use close icon and no close thick

Signed-off-by: fenn-cs <[email protected]>
  • Loading branch information
@nfebe @AndyScherzinger
nfebe authored and AndyScherzinger committed Nov 29, 2023
commit 1fe7ba57c868fca92deb8ed0e582858dbc5fe50d
18 changes: 11 additions & 7 deletions core/src/components/GlobalSearch/SearchFilterChip.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,28 @@
</span>
<span class="text">{{ text }}</span>
<span class="close-icon" @click="deleteChip">
<CloseIcon :size="16" />
<CloseIcon :size="18" />
</span>
</div>
</template>

<script>
import CloseIcon from 'vue-material-design-icons/CloseThick.vue'
import CloseIcon from 'vue-material-design-icons/Close.vue'

export default {
name: 'SearchFilterChip',
components: {
CloseIcon,
},
props: {
text: String,
pretext: String,
text: {
type: String,
required: true,
},
pretext: {
type: String,
required: true,
},
},
methods: {
deleteChip() {
Expand All @@ -40,8 +46,6 @@ export default {
border-radius: 20px;
background-color: var(--color-primary-element-light);
margin: 2px;
font-size: 10px;
font-weight: bolder;

.icon {
display: flex;
Expand All @@ -61,7 +65,7 @@ export default {
}

.close-icon {
cursor: pointer;
cursor: pointer ;

:hover {
filter: invert(20%);
Expand Down