Skip to content

[stable28] fix(a11y): Unified search headings #42131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Dec 14, 2023
Merged

[stable28] fix(a11y): Unified search headings #42131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions core/src/views/GlobalSearchModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<template>
<NcModal id="global-search"
ref="globalSearchModal"
:name="t('core', 'Unified search')"
:show.sync="internalIsVisible"
:clear-view-delay="0"
@close="closeModal">
Expand All @@ -11,7 +10,9 @@
@update:is-open="showDateRangeModal = $event" />
<!-- Global search form -->
<div ref="globalSearch" class="global-search-modal">
<h1>{{ t('core', 'Unified search') }}</h1>
<h2 class="global-search-modal__heading">
{{ t('core', 'Unified search') }}
</h2>
<NcInputField ref="searchInput"
:value.sync="searchQuery"
type="text"
Expand Down Expand Up @@ -537,10 +538,11 @@ export default {
padding: 10px 20px 10px 20px;
height: 60%;

h1 {
&__heading {
font-size: 16px;
font-weight: bolder;
line-height: 2em;
margin-bottom: 0;
}

&__filters {
Expand Down
4 changes: 2 additions & 2 deletions dist/core-global-search.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-global-search.js.map
View file
Open in desktop

Large diffs are not rendered by default.