fix(files_sharing): Add one string for every share type #42185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
emoral435,
rakekniven,
sorbaugh and
szaimen
and removed request for
a team
Contributor
Author
|
/compile |
rakekniven
approved these changes
Dec 13, 2023
Member
rakekniven
left a comment
rakekniven
left a comment
There was a problem hiding this comment.
I cannot judge the code 100% but the idea is covered. Great.
emoral435
reviewed
Dec 13, 2023
emoral435
approved these changes
Dec 13, 2023
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Looks good to me : ) love seeing switch statements 👌
emoral435
force-pushed
the
fix/files-sharing-translations
branch
from
6776163 to
80e1301
Compare
… any language Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-sharing-translations
branch
from
80e1301 to
a7795e2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not assume any order of words for translatable string but be explicit and add a string for every type.
Checklist