Skip to content

fix(files_sharing): Add one string for every share type #42185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Dec 13, 2023
Merged

fix(files_sharing): Add one string for every share type #42185

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35f6d8
fix(files_sharing): Add one string for every share type to not assume…
susnux Dec 13, 2023
a7795e2
chore: Compile assets
susnux Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files_sharing): Add one string for every share type to not assume… 
… any language

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Dec 13, 2023
commit e35f6d89a271eede8380e9513811edfe923db4de
34 changes: 17 additions & 17 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,24 +305,24 @@ export default {

computed: {
title() {
let title = t('files_sharing', 'Share with ')
if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_USER) {
title = title + this.share.shareWithDisplayName
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK) {
title = t('files_sharing', 'Share link')
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_GROUP) {
title += ` (${t('files_sharing', 'group')})`
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_ROOM) {
title += ` (${t('files_sharing', 'conversation')})`
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_REMOTE) {
title += ` (${t('files_sharing', 'remote')})`
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_REMOTE_GROUP) {
title += ` (${t('files_sharing', 'remote group')})`
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_GUEST) {
title += ` (${t('files_sharing', 'guest')})`
switch (this.share.type) {
case this.SHARE_TYPES.SHARE_TYPE_USER:
return t('files_sharing', 'Share with {userName}', { userName: this.share.shareWithDisplayName })
case this.SHARE_TYPES.SHARE_TYPE_LINK:
return t('files_sharing', 'Share link')
case this.SHARE_TYPES.SHARE_TYPE_GROUP:
return t('files_sharing', 'Share with group')
case this.SHARE_TYPES.SHARE_TYPE_ROOM:
return t('files_sharing', 'Share in conversation')
case this.SHARE_TYPES.SHARE_TYPE_REMOTE:
return t('files_sharing', 'Share with remote')
case this.SHARE_TYPES.SHARE_TYPE_REMOTE_GROUP:
return t('files_sharing', 'Share with remote group')
case this.SHARE_TYPES.SHARE_TYPE_GUEST:
return t('files_sharing', 'Share with guest')
default:
return t('files_sharing', 'Share with')
}

return title
},
/**
* Can the sharee edit the shared file ?
Expand Down