Switch OCP authentication exceptions to interfaces #42579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure catching OCP or OC version is the same thing, and ease transition. Signed-off-by: Côme Chilliet <[email protected]>
| /** | ||
| * @since 28.0.0 | ||
| */ | ||
| class InvalidTokenException extends Exception { |
Member
There was a problem hiding this comment.
This exception is used by apps already, quick local search at least found 2 (1 shipped, 1 community)
- notifications: https://github.com/nextcloud/notifications/blob/5479d707185c8c310296dac7e0b99435e8db7eed/lib/Controller/PushController.php#L35
- registration: https://github.com/nextcloud/registration/blob/6b52d5a95fc5c082a232e0df91b3d033aefe8a56/lib/Service/RegistrationService.php#L52
4 tasks
nickvergessen
requested changes
Jan 10, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Blocking this as I prefer #42640
Contributor
Author
|
Replaced by #42640 |
nickvergessen
deleted the
fix/fix-authentication-exceptions-with-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure catching OCP or OC version is the same thing, and ease
transition.
Summary
This is an alternate solution to #42577
It feels cleaner and will ease transition from 27 to 28.0.2, but it introduce breakage for 28 to 28.0.2 which I’m not sure how to fix.
Checklist