Always catch OCP versions of authentication exceptions #42640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
come-nc
added
3. to review
Contributor
Author
|
/backport to stable28 |
come-nc
force-pushed
the
fix/fix-authentication-exceptions-2
branch
from
2f1726e to
a2c3113
Compare
This was referenced Jan 10, 2024
ChristophWurst
approved these changes
Jan 10, 2024
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good and preferable over the alternatives
And always throw OC versions for BC Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fix-authentication-exceptions-2
branch
from
0064671 to
37a6e15
Compare
Signed-off-by: Côme Chilliet <[email protected]>
nickvergessen
approved these changes
Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Always catch OCP versions of authentication exceptions.
And always throw OC versions for BC.
Alternative to #42577 and #42579 which simply fix internal uses instead of trying to fix back OC Exceptions inheritance.
Checklist