Skip to content

[stable28] fix(a11y): Fix informative graphics contrast of user status icons #43066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 4 commits into from
Feb 2, 2024
Merged

[stable28] fix(a11y): Fix informative graphics contrast of user status icons #43066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e429435
fix(dashboard): Migrate to NcUserStatusIcon
Pytal Jan 12, 2024
6553d91
fix(user_status): Migrate to NcUserStatusIcon
Pytal Jan 12, 2024
72c0626
chore(user_status): Remove unused styles + svgs
Pytal Jan 12, 2024
579242e
chore: Compile assets
susnux Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(user_status): Remove unused styles + svgs 
Signed-off-by: Christopher Ng <[email protected]>
(cherry picked from commit b61c13c)
  • Loading branch information
@Pytal @susnux
Pytal authored and susnux committed Feb 2, 2024
commit 72c0626ac388a3feb77f9094f79dd8eeeb52b5b6
2 changes: 1 addition & 1 deletion apps/user_status/css/user-status-menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
.icon-user-status{background-image:url("../img/app.svg")}.icon-user-status-dark{background-image:url("../img/app-dark.svg")}.icon-user-status-online{background-image:url("../img/user-status-online.svg")}.icon-user-status-away{background-image:url("../img/user-status-away.svg")}.icon-user-status-dnd{background-image:url("../img/user-status-dnd.svg")}.icon-user-status-invisible{background-image:url("../img/user-status-invisible.svg");filter:var(--background-invert-if-dark)}/*# sourceMappingURL=user-status-menu.css.map */
.icon-user-status{background-image:url("../img/app.svg")}.icon-user-status-dark{background-image:url("../img/app-dark.svg")}/*# sourceMappingURL=user-status-menu.css.map */
2 changes: 1 addition & 1 deletion apps/user_status/css/user-status-menu.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 0 additions & 17 deletions apps/user_status/css/user-status-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,3 @@
background-image: url("../img/app-dark.svg");

}

.icon-user-status-online {
background-image: url('../img/user-status-online.svg');
}

.icon-user-status-away {
background-image: url('../img/user-status-away.svg');
}

.icon-user-status-dnd {
background-image: url('../img/user-status-dnd.svg');
}

.icon-user-status-invisible {
background-image: url('../img/user-status-invisible.svg');
filter: var(--background-invert-if-dark);
}
1 change: 0 additions & 1 deletion apps/user_status/img/user-status-away.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion apps/user_status/img/user-status-dnd.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion apps/user_status/img/user-status-invisible.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion apps/user_status/img/user-status-online.svg
View file
Open in desktop

This file was deleted.