Skip to content

[stable28] fix(a11y): Fix informative graphics contrast of user status icons #43066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 4 commits into from
Feb 2, 2024
Merged

[stable28] fix(a11y): Fix informative graphics contrast of user status icons #43066

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e429435
fix(dashboard): Migrate to NcUserStatusIcon
Pytal Jan 12, 2024
6553d91
fix(user_status): Migrate to NcUserStatusIcon
Pytal Jan 12, 2024
72c0626
chore(user_status): Remove unused styles + svgs
Pytal Jan 12, 2024
579242e
chore: Compile assets
susnux Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(dashboard): Migrate to NcUserStatusIcon 
Signed-off-by: Christopher Ng <[email protected]>
(cherry picked from commit 693eb69)
  • Loading branch information
@Pytal @susnux
Pytal authored and susnux committed Feb 2, 2024
commit e429435349e6ae47f6a70e90e314486955ec8c78
6 changes: 4 additions & 2 deletions apps/dashboard/src/DashboardApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@
:checked="isStatusActive(status)"
@input="updateStatusCheckbox(status, $event.target.checked)">
<label :for="'status-checkbox-' + status">
<span :class="statusInfo[status].icon" aria-hidden="true" />
<NcUserStatusIcon v-if="status === 'status'" status="online" aria-hidden="true" />
<span v-else :class="statusInfo[status].icon" aria-hidden="true" />
{{ statusInfo[status].text }}
</label>
</li>
Expand Down Expand Up @@ -124,6 +125,7 @@ import axios from '@nextcloud/axios'
import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
import Draggable from 'vuedraggable'
import NcModal from '@nextcloud/vue/dist/Components/NcModal.js'
import NcUserStatusIcon from '@nextcloud/vue/dist/Components/NcUserStatusIcon.js'
import Pencil from 'vue-material-design-icons/Pencil.vue'
import Vue from 'vue'

Expand All @@ -140,7 +142,6 @@ const statusInfo = {
},
status: {
text: t('dashboard', 'Status'),
icon: 'icon-user-status-online',
},
}

Expand All @@ -152,6 +153,7 @@ export default {
Draggable,
NcModal,
Pencil,
NcUserStatusIcon,
},
mixins: [
isMobile,
Expand Down