Skip to content

[stable28] fix(files): Allow to set node name before creating + bring back new-file highlingting #43470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 4 commits into from
Feb 10, 2024
Merged

[stable28] fix(files): Allow to set node name before creating + bring back new-file highlingting #43470

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1c1ce7
enh(files): Add modal to set filename before creating new files in th…
susnux Jan 21, 2024
139dfab
fix(files): Fix some type errors in TemplatePicker
susnux Jan 21, 2024
0a71193
fix(files): Do not scroll if there is no scrolling area
susnux Jan 31, 2024
51e7e24
chore: Compile assets
susnux Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(files): Do not scroll if there is no scrolling area 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @skjnldsv
susnux authored and skjnldsv committed Feb 10, 2024
commit 0a71193436e85be0b3f12e0e6c78108392e0a8bb
5 changes: 5 additions & 0 deletions apps/files/src/components/VirtualList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,11 @@ export default Vue.extend({

methods: {
scrollTo(index: number) {
const targetRow = Math.ceil(this.dataSources.length / this.columnCount)
if (targetRow < this.rowCount) {
logger.debug('VirtualList: Skip scrolling. nothing to scroll', { index, targetRow, rowCount: this.rowCount })
return
}
this.index = index
// Scroll to one row and a half before the index
const scrollTop = (Math.floor(index / this.columnCount) - 0.5) * this.itemHeight + this.beforeHeight
Expand Down