Fix undefined share object during expirationDate update #43661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
approved these changes
Feb 20, 2024
In 04e8733 a regression was introduced. `this` means nothing inside arrow functions, hence this.share was referring to an undefined object and so all attempted updates for expiration dates would fail. Resolves : #43256 Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
43256-fix-update-share-expiration-date
branch
from
92e8cc1 to
82cdc10
Compare
Contributor
Author
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
Contributor
Author
|
/backport to stable28 |
2 tasks
Contributor
Author
|
/backport to stable27 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 04e8733 a regression was introduced.
thismeans nothing inside arrow functions, hence this.share was referring to an undefined object and so all attempted updates for expiration dates would fail.Resolves : #43256