[stable27] Fix undefined share object during expirationDate update #43686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
3. to review
nfebe
force-pushed
the
backport/43661/stable27
branch
from
2a5a272 to
2df4311
Compare
nfebe
approved these changes
Feb 20, 2024
Contributor
|
/compile |
emoral435
approved these changes
Feb 20, 2024
Altahrim
approved these changes
Feb 20, 2024
skjnldsv
added
4. to release
Merged
In 04e8733 a regression was introduced. `this` means nothing inside arrow functions, hence this.share was referring to an undefined object and so all attempted updates for expiration dates would fail. Resolves : #43256 Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
solracsf
force-pushed
the
backport/43661/stable27
branch
from
4004615 to
8d386ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #43661
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
[skip ci]tagLearn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.