Skip to content

[stable26] Check share status when touching versions #43739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 5 commits into from
Feb 22, 2024
Merged

[stable26] Check share status when touching versions #43739

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5c4c2a
Check share attributes when downloading versions
artonge Feb 13, 2024
231e27c
Check node permissions when deleting a version
artonge Feb 13, 2024
ee7c577
Check node permissions when restoring a version
artonge Feb 13, 2024
37df1b7
Check permissions when labeling a version
artonge Feb 21, 2024
c70b869
Hide some actions based on node permissions and share attributes
artonge Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check node permissions when restoring a version 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Feb 21, 2024
commit ee7c5778f6c3c6d81a4c4599d48be787dac2434b
4 changes: 4 additions & 0 deletions apps/files_versions/lib/Versions/LegacyVersionsBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ public function createVersion(IUser $user, FileInfo $file) {
}

public function rollback(IVersion $version) {
if (!$this->currentUserHasPermissions($version, \OCP\Constants::PERMISSION_UPDATE)) {
throw new Forbidden('You cannot restore this version because you do not have update permissions on the source file.');
}

return Storage::rollback($version->getVersionPath(), $version->getRevisionId(), $version->getUser());
}

Expand Down