[stable26] Check share status when touching versions #43739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
3. to review
Contributor
|
/compile amend / |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // The version source file is relative to the owner storage. | ||
| // But we need the node from the current user perspective. | ||
| if ($node->getOwner()->getUID() !== $currentUserId) { | ||
| $nodes = $this->userFolder->getById($node->getId()); |
Check notice
Code scanning / Psalm
PossiblyNullReference
| // The version source file is relative to the owner storage. | ||
| // But we need the node from the current user perspective. | ||
| if ($node->getOwner()->getUID() !== $currentUserId) { | ||
| $nodes = $this->userFolder->getById($node->getId()); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
Member
|
psalm says no |
artonge
force-pushed
the
backport/43727/stable26
branch
2 times, most recently
from
8889779 to
216c94c
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
backport/43727/stable26
branch
from
216c94c to
38302dc
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
backport/43727/stable26
branch
from
38302dc to
1d84ff3
Compare
| throw new NotFoundException("No user logged in"); | ||
| } | ||
|
|
||
| if ($sourceFile->getOwner()?->getUID() !== $currentUserId) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| throw new NotFoundException("No user logged in"); | ||
| } | ||
|
|
||
| if ($sourceFile->getOwner()?->getUID() !== $currentUserId) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
artonge
force-pushed
the
backport/43727/stable26
branch
3 times, most recently
from
74a7f36 to
37df1b7
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
approved these changes
Feb 21, 2024
skjnldsv
approved these changes
Feb 22, 2024
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #43727
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.