fix(updatenotification): a11y of channel menu and new icons #43746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
requested review from
JuliaKirschenheuter,
Pytal,
emoral435,
jancborchardt,
skjnldsv,
susnux and
szaimen
ShGKme
force-pushed
the
fix/updatenotification--actions-a11y
branch
2 times, most recently
from
752303b to
6a73e97
Compare
susnux
approved these changes
Feb 22, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
lgtm
ref for icons: nextcloud-libraries/nextcloud-vue#5284
skjnldsv
approved these changes
Feb 22, 2024
emoral435
approved these changes
Feb 22, 2024
ShGKme
force-pushed
the
fix/updatenotification--actions-a11y
branch
from
6a73e97 to
6c1da91
Compare
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
skjnldsv
added
4. to release
skjnldsv
force-pushed
the
fix/updatenotification--actions-a11y
branch
from
6c1da91 to
fd4ced0
Compare
Contributor
Author
|
/backport to stable28 |
2 tasks
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
@ShGKme small detail: The icons seem to have gone from top-aligned with the headings (as intended design-wise) to center-aligned. Could that be fixed back? :)
Contributor
Member
|
@susnux ah thanks! :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A11y fix
Before there were custom attributes for
menuitemradiowhich were not fully correct.buttonwas insidemenuitemradiobut has to bemenuitemradioitselfaria-labelis not neededaria-checkedshould be on the same element asmenuitemradioSince
NcActionButtonnow supports radio out of the box, use it to have correct a11y attributes and consistent styles.Icons update
Checkicon on Stable doesn't look good together withCheckon checked variant.Replaced with Check in clouds. Also added icons for Daily and Git channels.
Checklist