feat: Make the app-level a component (AppLevelBadge)
#43770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
enh/split-appstore-app-level
branch
from
fb3b63a to
1e47046
Compare
Contributor
Author
|
I guess this was already ready-to-review 2 weeks ago 🙈 |
susnux
force-pushed
the
enh/split-appstore-app-level
branch
2 times, most recently
from
22efdb5 to
a776d24
Compare
szaimen
approved these changes
Mar 6, 2024
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Code looks fine but didnt test
susnux
force-pushed
the
enh/split-appstore-app-level
branch
from
a776d24 to
a53abe9
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
enh/split-appstore-app-level
branch
from
a53abe9 to
63f4c79
Compare
skjnldsv
approved these changes
Mar 6, 2024
skjnldsv
approved these changes
Mar 6, 2024
Pytal
approved these changes
Mar 6, 2024
4 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code refactoring to reduce duplicated code and make the appstore part better maintainable.
Checklist