Skip to content

[stable28] fix(settings): apps list layout #44327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sorbaugh merged 2 commits into from
Feb 4, 2025
Merged

[stable28] fix(settings): apps list layout #44327

sorbaugh merged 2 commits into from
Feb 4, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 19, 2024 •
edited by ShGKme
Loading

Backport of #44236

Full backport occurs too complicated due to the large refactoring of this app in Nextcloud 29.
Complete backport with a propper solution would require backporting at least the following large PRs:

To make it much simpler and less risky - backporting only 1 commit that fixes the linked Safari issue with apps list scrolling, adapting it to the Nextcloud 28 state.

Tested on:

  • Chromium
  • Firefox
  • Safari on macOS

Tested cases:

  • Apps list (active)
  • Apps bundles on a 320 px screen (slightly cut)
  • Apps store with a grid view
Screen.Recording.2025-02-04.at.12.42.56.mov

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from ShGKme, artonge and susnux March 19, 2024 15:37
@backportbot backportbot bot added this to the Nextcloud 28.0.4 milestone Mar 19, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Mar 19, 2024

Backport is not complete

@ShGKme ShGKme added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 19, 2024
@Altahrim Altahrim mentioned this pull request Mar 21, 2024
Merged
9 tasks
@joshtrichards joshtrichards mentioned this pull request Mar 28, 2024
Closed
8 tasks
@SystemKeeper SystemKeeper mentioned this pull request Mar 29, 2024
Open
8 tasks
@solracsf solracsf linked an issue Mar 29, 2024 that may be closed by this pull request
[Bug]: No scrolling on apps page #44568
Open
8 tasks
@susnux susnux added the high label Mar 29, 2024
@susnux susnux mentioned this pull request Mar 29, 2024
Merged
4 tasks
@susnux
Copy link
Contributor

susnux commented Apr 3, 2024

@ShGKme do you think you can get this ready for 28.0.5?

@szaimen
Copy link
Contributor

szaimen commented Jun 12, 2024

@ShGKme any update here? :)

@Rello
Copy link
Contributor

Rello commented Jun 19, 2024

@ShGKme Hi Grigorii
also having it on my instance can not enable/disable apps due to this. any news?

@nextcloud nextcloud deleted a comment from GretaD Oct 15, 2024
@blizzz blizzz removed this from the Nextcloud 28.0.13 milestone Dec 5, 2024
@blizzz
Copy link
Member

blizzz commented Dec 5, 2024

@ShGKme keep or close?

@blizzz
Copy link
Member

blizzz commented Dec 5, 2024

Keep i hear

@ShGKme
Copy link
Contributor

ShGKme commented Feb 3, 2025

Full backport occurs too complicated due to the large refactoring of this app in Nextcloud 29.
Complete backport with a propper solution would require backporting at least the following large PRs:

To make it much simpler and less risky - backporting only 1 commit that fixes the linked Safari issue with apps list scrolling, adapting it to the Nextcloud 28 state.

Tested on:

  • Chromium
  • Firefox
  • Safari on macOS

Tested cases:

  • Apps list (active)
  • Apps bundles on a 320 px screen (slightly cut)
  • Apps store with a grid view

@ShGKme ShGKme force-pushed the backport/44236/stable28 branch from 858c61f to 0056ba7 Compare February 3, 2025 21:46
@ShGKme ShGKme requested a review from GretaD February 3, 2025 21:47
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 3, 2025
@ShGKme ShGKme force-pushed the backport/44236/stable28 branch from 0056ba7 to bfb444c Compare February 3, 2025 21:51
@ShGKme ShGKme marked this pull request as ready for review February 3, 2025 21:51
@ShGKme ShGKme requested review from susnux and removed request for susnux February 3, 2025 22:04
GretaD
GretaD approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Louis has to recheck because he approved the initial version of this

@GretaD GretaD requested a review from artonge February 4, 2025 10:38
susnux
susnux approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

ShGKme added 2 commits February 4, 2025 12:35
@ShGKme @susnux
fix(settings): app list scroll on Safari
6cccb90 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @susnux
chore(assets): Recompile assets
d14071e 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@susnux susnux force-pushed the backport/44236/stable28 branch from bfb444c to d14071e Compare February 4, 2025 11:35
@ShGKme
Copy link
Contributor

ShGKme commented Feb 4, 2025

Added screen cast of the fix

@sorbaugh sorbaugh merged commit 656c941 into stable28 Feb 4, 2025
46 of 47 checks passed
@sorbaugh sorbaugh deleted the backport/44236/stable28 branch February 4, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@GretaD GretaD GretaD approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@artonge artonge Awaiting requested review from artonge

Assignees

@ShGKme ShGKme

Labels

3. to review Waiting for reviews bug feature: settings high regression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: No scrolling on apps page