Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 27, 2024

Backport of #43727

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, skjnldsv and susnux February 27, 2024 09:48
@backportbot backportbot bot added 3. to review Waiting for reviews feature: versions javascript php Pull requests that update Php code labels Feb 27, 2024
@artonge artonge force-pushed the backport/43727/stable25 branch 3 times, most recently from bc3a1f1 to 998d3bc Compare February 27, 2024 10:06
@artonge artonge marked this pull request as ready for review February 27, 2024 10:06
@artonge artonge force-pushed the backport/43727/stable25 branch from 998d3bc to 26eae60 Compare February 27, 2024 10:34
} else if ($davNode instanceof VersionFile) {
} elseif ($davNode instanceof VersionFile) {
$node = $davNode->getVersion()->getSourceFile();
$currentUserId = $this->userFolder->getOwner()->getUID();

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method getOwner on possibly null value
@artonge
Copy link
Contributor

artonge commented Feb 27, 2024

/backport to stable24

@artonge artonge force-pushed the backport/43727/stable25 branch from 26eae60 to 4c289aa Compare February 27, 2024 11:08
@artonge
Copy link
Contributor

artonge commented Feb 27, 2024

CI failure unrelated

@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2024
@sorbaugh sorbaugh merged commit 00bee4f into stable25 Feb 27, 2024
@sorbaugh sorbaugh deleted the backport/43727/stable25 branch February 27, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: versions javascript php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants