Check share status when touching versions #43727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
added
3. to review
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
Contributor
Author
|
/backport to stable26 |
artonge
force-pushed
the
artonge/fix/prevent_download_of_shares
branch
from
d4726e9 to
7f6ff98
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $currentUserId = $this->userFolder?->getOwner()?->getUID(); | ||
| // The version source file is relative to the owner storage. | ||
| // But we need the node from the current user perspective. | ||
| if ($node->getOwner()->getUID() !== $currentUserId) { |
Check notice
Code scanning / Psalm
PossiblyNullReference
| // The version source file is relative to the owner storage. | ||
| // But we need the node from the current user perspective. | ||
| if ($node->getOwner()->getUID() !== $currentUserId) { | ||
| $nodes = $this->userFolder->getById($node->getId()); |
Check notice
Code scanning / Psalm
PossiblyNullReference
| // The version source file is relative to the owner storage. | ||
| // But we need the node from the current user perspective. | ||
| if ($node->getOwner()->getUID() !== $currentUserId) { | ||
| $nodes = $this->userFolder->getById($node->getId()); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| // Allow view-only plugin for webdav requests | ||
| $this->server->addPlugin(new ViewOnlyPlugin( | ||
| $logger | ||
| \OC::$server->getUserFolder(), |
Check notice
Code scanning / Psalm
DeprecatedMethod
| } | ||
|
|
||
| if ($sourceFile->getOwner()?->getUID() !== $currentUserId) { | ||
| $nodes = $this->rootFolder->getUserFolder($currentUserId)->getById($sourceFile->getId()); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/prevent_download_of_shares
branch
from
7f6ff98 to
18b32e8
Compare
susnux
approved these changes
Feb 21, 2024
skjnldsv
reviewed
Feb 21, 2024
skjnldsv
approved these changes
Feb 21, 2024
This was referenced Feb 21, 2024
Contributor
Author
|
/backport 8e95d0f to stable25 |
2 tasks
Contributor
Author
Contributor
Author
2 tasks
2 tasks
Contributor
Author
2 tasks
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.