fix(UpdateNotifications): Handle numeric user ids #44093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #44051 Signed-off-by: Josh <[email protected]>
joshtrichards
added
bug
3. to review
nickvergessen
approved these changes
Mar 8, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| foreach ($this->getUsersToNotify() as $uid) { | ||
| $notification->setUser($uid); | ||
| $notification->setUser((string) $uid); |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType
|
|
||
| foreach ($this->getUsersToNotify() as $uid) { | ||
| $notification->setUser($uid); | ||
| $notification->setUser((string) $uid); |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType
joshtrichards
added a commit
that referenced
this pull request
Mar 8, 2024
manual backport of #44093 to fix #44051 for <=v28 Signed-off-by: Josh <[email protected]>
4 tasks
Contributor
This is no longer the case, |
Member
|
28 and lower with the bug is fixed via #44095 |
backportbot bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
manual backport of #44093 to fix #44051 for <=v28 Signed-off-by: Josh <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
manual backport of #44093 to fix #44051 for <=v28 Signed-off-by: Josh <[email protected]>
joshtrichards
added a commit
that referenced
this pull request
Mar 10, 2024
manual backport of #44093 to fix #44051 for <=v28 Signed-off-by: Josh <[email protected]>
joshtrichards
added a commit
that referenced
this pull request
Mar 12, 2024
manual backport of #44093 to fix #44051 for <=v28 Signed-off-by: Josh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getUsersToNotify()usesarray_keyso when$uidhappens to be numeric it ends up needing to be cast here (similar to #15912).Backports will need to be done manually due to restructure that occurred in >v28 (I'll follow-up with those).
TODO
Checklist