Skip to content

fix(UpdateNotifications): Handle numeric user ids #44093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshtrichards wants to merge 1 commit into from
Closed

fix(UpdateNotifications): Handle numeric user ids #44093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/updatenotification/lib/BackgroundJob/UpdateAvailableNotifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ protected function sendErrorNotifications($numDays) {
->setSubject('connection_error', ['days' => $numDays]);

foreach ($this->getUsersToNotify() as $uid) {
$notification->setUser($uid);
$notification->setUser((string) $uid);

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType

Redundant cast to string given docblock-provided type
$this->notificationManager->notify($notification);
}
} catch (\InvalidArgumentException $e) {
Expand Down Expand Up @@ -189,7 +189,7 @@ protected function createNotifications($app, $version, $visibleVersion = '') {
}

foreach ($this->getUsersToNotify() as $uid) {
$notification->setUser($uid);
$notification->setUser((string) $uid);

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType

Redundant cast to string given docblock-provided type
$this->notificationManager->notify($notification);
}
} catch (\InvalidArgumentException $e) {
Expand Down