feat: Limit email input to 255 chars #44218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
613-limit-auth-input-emails-255
branch
2 times, most recently
from
00a96a9 to
21c61c8
Compare
nickvergessen
changed the title
nfebe
force-pushed
the
613-limit-auth-input-emails-255
branch
2 times, most recently
from
4f9dee4 to
b6a0c6a
Compare
nfebe
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nfebe
force-pushed
the
613-limit-auth-input-emails-255
branch
from
b6a0c6a to
c9ca17d
Compare
Member
|
Labels pleaaase :) |
susnux
reviewed
Mar 17, 2024
Merged
nfebe
force-pushed
the
613-limit-auth-input-emails-255
branch
from
c9ca17d to
301b3d4
Compare
| return $this->createLoginFailedResponse( | ||
| $user, | ||
| $user, | ||
| $redirect_url, |
Check notice
Code scanning / Psalm
PossiblyNullArgument
Collaborator
There was a problem hiding this comment.
Maybe the following or change default on line 317:
Suggested change
| $redirect_url, | |
| (string) $redirect_url, |
Altahrim
reviewed
Mar 20, 2024
Merged
nfebe
force-pushed
the
613-limit-auth-input-emails-255
branch
from
301b3d4 to
ada4138
Compare
susnux
reviewed
Mar 20, 2024
nfebe
force-pushed
the
613-limit-auth-input-emails-255
branch
from
ada4138 to
4a80230
Compare
susnux
approved these changes
Mar 20, 2024
Altahrim
approved these changes
Mar 21, 2024
Excessively long emails reported make server unresponsive. We could at some point, consider adding a configuration for sysadmins to bypass this setting on their instance if they want. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
613-limit-auth-input-emails-255
branch
from
4a80230 to
2792d8b
Compare
Contributor
Author
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
2 tasks
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots