Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented May 13, 2024

Backport of #44218

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Altahrim, nfebe and susnux May 13, 2024 10:49
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels May 13, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.6 milestone May 13, 2024
@nfebe nfebe marked this pull request as ready for review May 13, 2024 10:51
@nfebe nfebe requested review from Pytal and artonge May 13, 2024 10:53
return $this->createLoginFailedResponse(
$user,
$user,
$redirect_url,

Check notice

Code scanning / Psalm

PossiblyNullArgument

Argument 3 of OC\Core\Controller\LoginController::createLoginFailedResponse cannot be null, possibly null value provided
This was referenced May 15, 2024
@joshtrichards
Copy link
Member

/compile rebase-amend /

@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2024
@joshtrichards joshtrichards enabled auto-merge May 28, 2024 21:27
nfebe and others added 2 commits May 28, 2024 21:29
Excessively long emails reported make server unresponsive.

We could at some point, consider adding a configuration for sysadmins to bypass this setting
on their instance if they want.

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the backport/44218/stable28 branch from 9c17362 to 9b44c8d Compare May 28, 2024 21:32
@joshtrichards joshtrichards merged commit 36ba08e into stable28 May 28, 2024
@joshtrichards joshtrichards deleted the backport/44218/stable28 branch May 28, 2024 22:21
@blizzz blizzz mentioned this pull request Jun 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants