Skip to content

Conversation

@icewind1991
Copy link
Member

To test:

  • add a favorite
  • go to "Favorites"
  • go to "All Files"
  • go back to "Favorites"

see also #4293

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 21, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Apr 21, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vgezer to be a potential reviewer.

@codecov
Copy link

codecov bot commented Apr 21, 2017

Codecov Report

Merging #4423 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4423      +/-   ##
============================================
+ Coverage     54.18%   54.18%   +<.01%     
  Complexity    21635    21635              
============================================
  Files          1327     1327              
  Lines         82778    82778              
  Branches       1312     1312              
============================================
+ Hits          44854    44855       +1     
+ Misses        37924    37923       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Security/CertificateManager.php 92.78% <0%> (-1.04%) 38% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 73.39% <0%> (-0.25%) 133% <0%> (ø)
lib/private/Server.php 93.35% <0%> (+0.14%) 120% <0%> (ø) ⬇️
apps/comments/lib/EventHandler.php 87.5% <0%> (+8.33%) 7% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 5605166 into master Apr 21, 2017
@MorrisJobke MorrisJobke deleted the reload-fav-view branch April 21, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants