feat(settings): Allow app discover section links to open app routes or the appstore page #44259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
3. to review
Contributor
|
From design perspective I'd say it would be better if the sidebar would open without switching views to your apps (by keeping the focus on the discover section). Would that be possible? |
Signed-off-by: Ferdinand Thiessen <[email protected]>
…pstore page Signed-off-by: Ferdinand Thiessen <[email protected]>
…uested Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/app-discover-app-links
branch
from
04d5d53 to
2dd2f58
Compare
Contributor
Author
|
@szaimen adjusted it like that. Looks like this: vokoscreenNG-2024-03-18_14-11-15.mp4 |
Contributor
Looks great, thanks! :) |
szaimen
approved these changes
Mar 18, 2024
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM from design perspective :)
nfebe
reviewed
Mar 18, 2024
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Generals looks good, waiting for wrap up?
Merged
nfebe
approved these changes
Mar 18, 2024
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/app-discover-app-links
branch
from
2dd2f58 to
3717dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows
app://{appid}links to open either the app if installed or the app store page.Also app routes like
app://files/trashbinare allowed, those will result in correct routes (e.g. incl. webroot).vokoscreenNG-2024-03-17_15-26-19.mp4
TODO
Checklist