Skip to content

feat(settings): Allow app discover section links to open app routes or the appstore page #44259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 4 commits into from
Mar 18, 2024
Merged

feat(settings): Allow app discover section links to open app routes or the appstore page #44259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44e0223
fix(settings): Adjust appstore types as `releases` are not always set
susnux Mar 17, 2024
7b1d1b3
feat(settings): Allow app discover links to open app routes or the ap…
susnux Mar 17, 2024
c6e75be
fix(settings): Open app details also on app discover section when req…
susnux Mar 18, 2024
3717dd8
chore: Compile assets
susnux Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(settings): Adjust appstore types as releases are not always set 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Mar 18, 2024
commit 44e0223ef92c4760d3cb502a21893605487b06a4
2 changes: 1 addition & 1 deletion apps/settings/src/app-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@ export interface IAppstoreApp {
isCompatible: boolean

appstoreData: Record<string, never>
releases: IAppstoreAppRelease[]
releases?: IAppstoreAppRelease[]
}
2 changes: 1 addition & 1 deletion apps/settings/src/components/AppStoreSidebar/AppReleasesTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ import Markdown from '../Markdown.vue'
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const props = defineProps<{ app: IAppstoreApp }>()

const hasChangelog = computed(() => Object.values(props.app.releases[0]?.translations ?? {}).some(({ changelog }) => !!changelog))
const hasChangelog = computed(() => Object.values(props.app.releases?.[0]?.translations ?? {}).some(({ changelog }) => !!changelog))

const createChangelogFromRelease = (release: IAppstoreAppRelease) => release.translations?.[getLanguage()]?.changelog ?? release.translations?.en?.changelog ?? ''
</script>
Expand Down