[stable25] Forbid tagging readonly files #44309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
backport/44299/stable25
branch
from
bcddd21 to
4016c22
Compare
come-nc
changed the title
This was referenced Mar 19, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $userSession, | ||
| $groupManager, | ||
| function ($name) { | ||
| function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType
| return !empty($nodes); | ||
| } | ||
| }, | ||
| function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
PossiblyNullReference
| $groupManager, | ||
| $entityExistsFunction | ||
| $entityExistsFunction, | ||
| fn ($name) => true, |
Check notice
Code scanning / Psalm
MissingClosureParamType
25 supports 7.4 Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
backport/44299/stable25
branch
from
4016c22 to
43865ac
Compare
Contributor
|
/backport! to stable24 |
Contributor
|
/backport! to stable23 |
nickvergessen
approved these changes
Mar 21, 2024
Contributor
|
Can someone restart drone job? Failures are weird. |
AndyScherzinger
approved these changes
Mar 21, 2024
come-nc
added
4. to release
Contributor
|
All good. Needs a force merge because 25 is EOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44299 / #44297
Warning, This backport's changes differ from the original and might be incomplete⚠️ Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.