Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 19, 2024

Backport of PR #44309 / #44297

@backportbot backportbot bot added the 3. to review Waiting for reviews label Mar 19, 2024
@come-nc come-nc changed the title [stable24] [stable25] Forbid tagging readonly files [stable24] Forbid tagging readonly files Mar 19, 2024
$userSession,
$groupManager,
function ($name) {
function ($name): bool {

Check notice

Code scanning / Psalm

MissingClosureParamType

Parameter $name has no provided type
return !empty($nodes);
}
},
function ($name): bool {

Check notice

Code scanning / Psalm

MissingClosureParamType

Parameter $name has no provided type
}
},
function ($name): bool {
$nodes = \OC::$server->getUserFolder()->getById((int)$name);

Check notice

Code scanning / Psalm

DeprecatedMethod

The method OC\Server::getUserFolder has been marked as deprecated
}
},
function ($name): bool {
$nodes = \OC::$server->getUserFolder()->getById((int)$name);

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method getById on possibly null value
$groupManager,
$entityExistsFunction
$entityExistsFunction,
fn ($name) => true,

Check notice

Code scanning / Psalm

MissingClosureParamType

Parameter $name has no provided type
@come-nc come-nc mentioned this pull request Mar 19, 2024
4 tasks
@come-nc come-nc self-assigned this Mar 19, 2024
@come-nc come-nc requested review from a team, Altahrim, ArtificialOwl and nfebe and removed request for a team March 21, 2024 10:44
@AndyScherzinger AndyScherzinger merged commit ce431b9 into stable24 Mar 21, 2024
@AndyScherzinger AndyScherzinger deleted the backport/44309/stable24 branch March 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants