[stable27] 44032 fix show new shares without refresh #44464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
3 times, most recently
from
b21988c to
c6a0d7c
Compare
nfebe
added
3. to review
Contributor
Author
|
/backport to master |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
nfebe
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
from
c6a0d7c to
1273195
Compare
artonge
reviewed
Apr 2, 2024
nfebe
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
from
1273195 to
22c9019
Compare
artonge
added
2. developing
Merged
nfebe
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
2 times, most recently
from
2b131e0 to
5fafe28
Compare
Contributor
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Altahrim
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
from
244d328 to
0913a8e
Compare
susnux
reviewed
May 3, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Logically makes sense, some code comments.
nfebe
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
5 times, most recently
from
1fc066c to
2cf97f3
Compare
Contributor
Author
|
/compile |
artonge
reviewed
May 6, 2024
nfebe
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
from
50b25a5 to
d08d477
Compare
Signed-off-by: fenn-cs <[email protected]>
These changes fixes the issue of having the refresh the UI after share creation, as the share is not immediately removed from the UI list. Important changes - The basis of checking wether a password/expire date is no longer based on config values alone because the config is not expected in a share creation circle. Hence we check the configs and check if the share object (this.share) has the expected values set. This way, once the required properties are set, code control does not enter the block meant to handle the setting of required properties unneccessarily. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
44032-fix-show-new-shares-without-refresh
branch
from
d08d477 to
2be6834
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced May 14, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #44032
Before
no-refresh.mp4
After
now-refresh.mp4