[stable29] 44032 fix show new shares without refresh #45304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
3. to review
solracsf
changed the title
nfebe
force-pushed
the
backport/44464/stable29
branch
from
4e99071 to
004401c
Compare
nfebe
approved these changes
May 16, 2024
Contributor
|
/compile |
skjnldsv
reviewed
Jun 7, 2024
skjnldsv
added
2. developing
nfebe
force-pushed
the
backport/44464/stable29
branch
3 times, most recently
from
50f6498 to
e43a35b
Compare
Contributor
|
/compile |
artonge
approved these changes
Jun 12, 2024
Member
|
There is a cypress error. Related or flaky? |
Signed-off-by: fenn-cs <[email protected]>
These changes fixes the issue of having the refresh the UI after share creation, as the share is not immediately removed from the UI list. Important changes - The basis of checking wether a password/expire date is no longer based on config values alone because the config is not expected in a share creation circle. Hence we check the configs and check if the share object (this.share) has the expected values set. This way, once the required properties are set, code control does not enter the block meant to handle the setting of required properties unneccessarily. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
backport/44464/stable29
branch
from
f7e6c62 to
34bd23d
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Contributor
@blizzz Not related, feel free to force merge if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44464
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.