fix: link preview folder icon color updated #44580
Conversation
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
solracsf
changed the title
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
@jadjoud could you include before/after screenshots? :) Also there seem to be some unrelated whitespace changes in the CSS file, not sure if that is an issue.
|
Thank you @jancborchardt |
@jadjoud screenshots basically always means UI screenshots, as the code is visible in the "Files changed" tab. :) |
|
Obvious haha, But the thing is I'm using github codespace and i have no idea how to run the branch and see the changes. Can you help, please? Thanks a lot! |
| target="_blank" | ||
| @click="navigate"> | ||
| <span class="widget-file__image" :class="filePreviewClass" :style="filePreviewStyle"> | ||
| <span class="widget-file__image" :class="filePreviewClass" :style="{ backgroundColor: primaryColor }"> |
There was a problem hiding this comment.
Why not simply putting this into the widget-file__image class styles? The color is never changed, no?
@jadjoud Ah ok, that is only online then right? Does it have no way of running a PHP application? It would be important to test it, so maybe you can set up a local instance? The documentation for how to do that is at: https://docs.nextcloud.com/server/latest/developer_manual/getting_started/devenv.html |
Yes i will try to setup the server locally and check the changes ! Thank you ! |
| cursor: pointer; | ||
| position: absolute; | ||
| z-index: 4; | ||
|
|
There was a problem hiding this comment.
nit: extra newline character that isn't needed
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
6 participants
Summary
color of the icon for folder link preview is primary like all the other icons
@jancborchardt
TODO
Checklist