Skip to content

chore(files): Switch widget icon to primary color #44806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 2 commits into from
Apr 16, 2024
Merged

chore(files): Switch widget icon to primary color #44806

Pytal merged 2 commits into from
Apr 16, 2024

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Apr 13, 2024 •
edited
Loading

Summary

  • Switch widget to primary color
    image

Checklist

@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 13, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Apr 13, 2024
@Pytal Pytal self-assigned this Apr 13, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner April 13, 2024 00:42
@Pytal
Copy link
Member Author

Pytal commented Apr 13, 2024

/backport to stable29

@Pytal Pytal enabled auto-merge April 13, 2024 00:43
@Pytal Pytal changed the title chore(files): Switch widget to primary color chore(files): Switch widget icon to primary color Apr 13, 2024
szaimen
szaimen approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

jancborchardt
jancborchardt requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder icons should indeed be primary color, but text documents not. :) If it’s a .doc/.odt, it has a distinct blue color, not primary (and this seems to be plain text, right?) @Pytal the correct coloring is in #44340 (comment)

susnux
susnux reviewed Apr 15, 2024
View reviewed changes
Pytal added 2 commits April 15, 2024 10:58
@Pytal
chore: Switch widget to primary color
ccede9b 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
chore: compile assets
d532cb0 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the chore/widget-primary-color branch from 2d0664d to d532cb0 Compare April 15, 2024 17:59
jancborchardt
jancborchardt approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@Pytal Pytal merged commit 9028137 into master Apr 16, 2024
@Pytal Pytal deleted the chore/widget-primary-color branch April 16, 2024 10:19
@backportbot backportbot bot mentioned this pull request Apr 16, 2024
Merged
2 tasks
This was referenced Apr 30, 2024
Closed
Closed
Closed
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal @jancborchardt @susnux @szaimen