[stable27] fix: avoid douple expireDate parsing
#44911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Apr 18, 2024
… logger Signed-off-by: fenn-cs <[email protected]>
`expireDate` can be set once and used anywhere needed, the current implementation, duplicates this behavior which leads to `parseDate` receiving an a date object it parsed and returend earlier in the createShare method. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
backport/44838/stable27
branch
from
1319b22 to
c902c22
Compare
nfebe
approved these changes
Apr 18, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| IPreview $previewManager, | ||
| private IDateTimeZone $dateTimeZone, | ||
| private LoggerInterface $logger, | ||
| ?string $userId = null |
Check failure
Code scanning / Psalm
DuplicateParam
| $expireDate = $this->parseDate($expireDate); | ||
| $share->setExpirationDate($expireDate); | ||
| } catch (\Exception $e) { | ||
| throw new OCSNotFoundException($this->l->t('Invalid date, date format must be YYYY-MM-DD')); |
Check failure
Code scanning / Psalm
UndefinedThisPropertyFetch
nfebe
requested changes
Apr 18, 2024
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Some update needs need to made as the backport is not totally graceful
solracsf
added
2. developing
nickvergessen
requested changes
Apr 18, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
This actually breaks Talk attachment:
https://github.com/nextcloud/spreed/actions/runs/8736657894/job/23972035833?pr=12147
| //Expire date | ||
| if ($expireDate !== '') { | ||
| try { | ||
| $expireDate = $this->parseDate($expireDate); |
Member
There was a problem hiding this comment.
Needs #44916 otherwise it breaks opencloudmesh, deck and talk
Contributor
|
Would backport #44912 [Same original PR but from stable28] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44838
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.