[stable28] fix: avoid douple expireDate parsing
#44912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Apr 18, 2024
nfebe
force-pushed
the
backport/44838/stable28
branch
from
d7c9de2 to
3cd5a7f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nfebe
force-pushed
the
backport/44838/stable28
branch
from
3cd5a7f to
4292ff6
Compare
nickvergessen
requested changes
Apr 18, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
This actually breaks Talk attachment:
https://github.com/nextcloud/spreed/actions/runs/8736657894/job/23972035833?pr=12147
nfebe
force-pushed
the
backport/44838/stable28
branch
3 times, most recently
from
396244f to
fc18a09
Compare
nfebe
approved these changes
Apr 20, 2024
2 tasks
Contributor
|
/backport to stable27 |
Member
|
It will only backport after the PR was merged, which will not be during the current RC freeze |
Merged
Altahrim
approved these changes
Apr 30, 2024
This was referenced Apr 30, 2024
nfebe
force-pushed
the
backport/44838/stable28
branch
2 times, most recently
from
1539611 to
1cf2bed
Compare
Member
|
@nickvergessen what's the status, is this good for you? |
Member
Contributor
|
@nickvergessen That has been handled here : #45604 |
nfebe
force-pushed
the
backport/44838/stable28
branch
from
1cf2bed to
9237d4c
Compare
… logger Signed-off-by: fenn-cs <[email protected]>
`expireDate` can be set once and used anywhere needed, the current implementation, duplicates this behavior which leads to `parseDate` receiving an a date object it parsed and returend earlier in the createShare method. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
backport/44838/stable28
branch
from
9237d4c to
e8b7a4b
Compare
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives. Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
backport/44838/stable28
branch
from
e8b7a4b to
4d748b9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44838
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.