Automatic mysql 4byte detection #4514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @j-ed and @LukasReschke to be potential reviewers. |
MorrisJobke
reviewed
Apr 27, 2017
lib/private/Repair/Collation.php
Outdated
| } | ||
| if (empty($tables)) { | ||
| $output->info('All tables already have the correct collation -> nothing to do'); | ||
| } |
Member
There was a problem hiding this comment.
I guess this is a merge conflict mishap 😉 - let me remove it
MorrisJobke
force-pushed
the
automatic-mysql-4byte-detection
branch
from
daa7875 to
05faaa6
Compare
MorrisJobke
approved these changes
Apr 27, 2017
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works 👍 (also the code makes sense)
Codecov Report
@@ Coverage Diff @@
## master #4514 +/- ##
=============================================
+ Coverage 31.37% 53.67% +22.29%
- Complexity 21898 22645 +747
=============================================
Files 1348 1361 +13
Lines 83372 86709 +3337
Branches 1334 1477 +143
=============================================
+ Hits 26161 46537 +20376
+ Misses 57211 40172 -17039
|
config.sample.php was updated to explicitly state that there detection in place to set mysql.utf8mb4
Signed-off-by: Joas Schilling <[email protected]>
rullzer
force-pushed
the
automatic-mysql-4byte-detection
branch
from
eeeeb3b to
0aa5ddf
Compare
Member
|
@rullzer @blizzz @icewind1991 please review this one |
ChristophWurst
approved these changes
May 8, 2017
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Changes make sense and code looks good. Just found a possible error in the config description.
config/config.sample.php
Outdated
| * and MySQL can handle 4 byte characters instead of 3 byte characters. | ||
| * | ||
| * If you want to convert an existing 3-byte setup into a 4-byte setup please | ||
| * set the parameters in MySQL as mentioned below run the migration command: |
Member
There was a problem hiding this comment.
"… set the parameters in MySQL as mentioned below and run the migration command: …"?
Signed-off-by: Joas Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of missing commits from 17978 and 27441