fix install on mb4 enabled mariadb/mysql #5209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
added
3. to review
Member
Author
|
Btw, upstream looks differently, they also moved the connect() method out of the abstract class and changed it e.g. not to accept dbname parameter at all. Perhaps some other commits missing there…? |
icewind1991
approved these changes
Jun 1, 2017
Member
Author
|
@karlitschek needs backport to 12, ok? |
Member
|
yep. please backport |
Member
Author
|
backport goes here #5217 |
nickvergessen
approved these changes
Jun 1, 2017
nickvergessen
added
4. to release
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix-install-mysql-mb4
branch
from
54b4498 to
18a8f36
Compare
Member
Author
|
rebased to revive CI, it got stuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Try to install against MariaDB/MySQL with mb4 support enabled (as described in https://docs.nextcloud.com/server/11/admin_manual/maintenance/mysql_4byte_support.html) by providing admin credentials to the DB. The target database does not exist at this moment.
NC 12 is affected.
Introduced by #4514 (downstream…)
Expected
Install succeeds
Reality
Error while trying to create admin user: Failed to connect to the database: An exception occured in driver: SQLSTATE[HY000] [1049] Unknown database 'stable12'
Fix
provide "null" as db name connection parameter as done with non-mb4-supported setup.