feature: Improved Recurrence Invitations Messages #45547
Conversation
SebastianKrupinski
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ChristophWurst
added
2. developing
|
TODO: unit tests |
SebastianKrupinski
force-pushed
the
feature/recurrence-invitations2
branch
from
7ce69d0 to
27b9da6
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
SebastianKrupinski
requested review from
ChristophWurst,
hamza221,
kesselb,
miaulalala and
st3iny
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
In general there are a lot of ternary operators. I'm not a big fan because they sacrifice readability for brevity.
I tagged the ones that are a bit problematic from my point of view. I'd also prefer some of the others to be refactored to regular if statements but have no hard opinions.
E.g. there are a lot of return cond ? a : b constructs.
It would also be nice to have some exemplary screenshots of the new messages or concrete steps for testing.
For testing just create a new calendar event with at least one attendee that has a valid email address. Here are some screenshots of the new messages... Singleton Partial Day Event
Singleton Complete Day Event
Recurring Daily Event
Recurring Weekly Event
Recurring Bi-Weekly Event
Recurring Month Event with Absolute Date
Recurring Monthly Event with Relative Date
|
SebastianKrupinski
force-pushed
the
feature/recurrence-invitations2
branch
from
7940339 to
fb4cf4a
Compare
SebastianKrupinski
added
3. to review
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
LGTM! Extensive unit tests are great.
SebastianKrupinski
force-pushed
the
feature/recurrence-invitations2
branch
from
fb4cf4a to
f60780e
Compare
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
feature/recurrence-invitations2
branch
from
f60780e to
43ee948
Compare
See nextcloud/calendar#5706 and FossifyOrg/Calendar#135 This issue was previously fixed in nextcloud#44938, but seems to have reverted in nextcloud#45547 Signed-off-by: Brett Bethke <[email protected]>
Summary
Improved Recurrence Invitations Messages