Fix for calendar invites not being sent in some cases

[bb4242]

• Resolves: New and updated appointments are not sent via e-mail calendar#5706

Summary

See nextcloud/calendar#5706 and FossifyOrg/Calendar#135

This issue was previously fixed in #44938, but seems to have reverted in #45547

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes (N/A)
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[bb4242]

/backport to stable30

[bb4242]

No backports earlier than stable30 are required since #44938 already patched those, and the regression was introduced in v30.

[bb4242]

I've tested this on my local nextcloud installation (v30.0.4) and verified that email notifications are properly sent when creating events using fossify Calendar on Android. Without this patch, notifications are not sent.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[bb4242]

@st3iny @SebastianKrupinski @tcitworld any chance this little PR could be reviewed? It would be great to get this fix for nextcloud/calendar#5706 in. Thank you! 🙏

[SebastianKrupinski]

@bb4242 I approve of the change, but I will need to recreate this PR as our CI will not pass for forked PR's.

[bb4242]

@bb4242 I approve of the change, but I will need to recreate this PR as our CI will not pass for forked PR's.

Thanks @SebastianKrupinski! Apologies if I didn't create the PR in the best way (this is my first contribution to nextcloud). Let me know if there's anything I can do to convert it to the format you need, or I'm also happy for you to do it if that's easier. Either way, thanks for your work on nextcloud, it's a great project! 😄 Best wishes.

[SebastianKrupinski]

@bb4242 Thank you for diagnosing this issue and making the PR.

Done. #50784

[SebastianKrupinski]

Thanks @SebastianKrupinski! Apologies if I didn't create the PR in the best way (this is my first contribution to nextcloud). Let me know if there's anything I can do to convert it to the format you need, or I'm also happy for you to do it if that's easier. Either way, thanks for your work on nextcloud, it's a great project! 😄 Best wishes.

No worries, you created the PR just fine, its just how our CI is setup for the server repo.

[bb4242]

Great, thanks @SebastianKrupinski!