[stable28] Respect empty expiryDate value in server

[backportbot]

Backport of #44485 via #45483

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

• Review and resolve any conflicts
• Amend HEAD commit to remove the line stating to skip CI

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[nfebe]

Way too many issues came up with back-porting this due to : #44029 being missing, added it.

[Antreesy]

Dismissing myself due to lack of PHP-knowledge 🦭
I believe Robin could approve that as author

[blizzz]

Resolved the conflict in apps/files_sharing/lib/Controller/ShareAPIController.php with this diff:

@@ -647,12 +648,18 @@ class ShareAPIController extends OCSController {
        }
 
        //Expire date
-       if ($expireDate !== '') {
-           try {
-               $expireDateTime = $this->parseDate($expireDate);
-               $share->setExpirationDate($expireDateTime);
-           } catch (\Exception $e) {
-               throw new OCSNotFoundException($this->l->t('Invalid date, date format must be YYYY-MM-DD'));
+       if ($expireDate !== null) {
+           if ($expireDate !== '') {
+               try {
+                   $expireDateTime = $this->parseDate($expireDate);
+                   $share->setExpirationDate($expireDateTime);
+               } catch (\Exception $e) {
+                   throw new OCSNotFoundException($this->l->t('Invalid date, date format must be YYYY-MM-DD'));
+               }
+           } else {
+               // Client sent empty string for expire date.
+               // Set noExpirationDate to true so overwrite is prevented.
+               $share->setNoExpirationDate(true);
            }
        }

The expire date section was not present previously.

[blizzz]

cannot judge the cypress failures.

[blizzz]

AssertionError: Timed out retrying after 4000ms: expected '<div.files-list__drag-drop-notice>' to be 'visible'

Keeps failing ^