Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 6, 2024

Fix #44318

  • Also fix various missing data for external shares
  • And also fix avatar for remote shares (+ dark avatar support)

Pending shares

Before After
2024-06-06_19-41_1 2024-06-06_19-41_2

Files list

Before After
2024-06-06_19-41 2024-06-06_19-42

@skjnldsv skjnldsv changed the title fix(files_sgaring): fix parsing of remote shares fix(files_shring): fix parsing of remote shares Jun 6, 2024
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, Pytal, artonge, nfebe, sorbaugh and szaimen and removed request for a team June 6, 2024 17:39
@skjnldsv skjnldsv force-pushed the fix/files-remote-shares branch from 29fd7ed to 8817417 Compare June 6, 2024 17:41
@skjnldsv skjnldsv requested review from come-nc and removed request for sorbaugh June 6, 2024 17:43
@AndyScherzinger AndyScherzinger changed the title fix(files_shring): fix parsing of remote shares fix(files_sharing): fix parsing of remote shares Jun 6, 2024
@szaimen szaimen removed their request for review June 6, 2024 20:01
@skjnldsv skjnldsv force-pushed the fix/files-remote-shares branch from 630e27c to 2211e6d Compare June 6, 2024 20:04
@provokateurin provokateurin self-requested a review as a code owner June 7, 2024 10:09
@skjnldsv skjnldsv requested a review from come-nc June 12, 2024 08:28
@skjnldsv skjnldsv force-pushed the fix/files-remote-shares branch from dddc173 to 00803f5 Compare June 12, 2024 08:28
@skjnldsv skjnldsv merged commit 4c32ab7 into master Jun 12, 2024
@skjnldsv skjnldsv deleted the fix/files-remote-shares branch June 12, 2024 11:02
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jun 12, 2024
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member

This seems to have added running some more heavy queries twice, filed at #46546

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Remote shares are not listed in share views

7 participants