Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jul 2, 2024

Backport of #45395

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from jancborchardt, susnux and szaimen July 2, 2024 20:23
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Jul 2, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.4 milestone Jul 2, 2024
@susnux susnux marked this pull request as ready for review July 10, 2024 22:32
@susnux susnux force-pushed the backport/45395/stable29 branch from 82e252e to dbabd56 Compare July 10, 2024 22:35
@susnux
Copy link
Contributor

susnux commented Jul 10, 2024

/backport! to stable28

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux force-pushed the backport/45395/stable29 branch from dbabd56 to 01a9064 Compare July 10, 2024 23:53
@susnux susnux enabled auto-merge July 10, 2024 23:54
@AndyScherzinger AndyScherzinger force-pushed the backport/45395/stable29 branch from 01a9064 to 914aa98 Compare July 11, 2024 06:22
@susnux susnux merged commit 1672d79 into stable29 Jul 11, 2024
@susnux susnux deleted the backport/45395/stable29 branch July 11, 2024 07:17
@Altahrim Altahrim mentioned this pull request Jul 11, 2024
@nickvergessen
Copy link
Member

Kind of related, don't you think 🤔
image

@susnux
Copy link
Contributor

susnux commented Jul 12, 2024

Kind of related, don't you think 🤔

It is but why was it merged? I enabled auto merge so it should not merge on error 👀

@SystemKeeper
Copy link
Contributor

SystemKeeper commented Jul 12, 2024

I enabled auto merge so it should not merge on error 👀

160 of 175 checks passed

phpunit-nodb-summary seems to be not marked as required? So all required passed -> merge

Edit: At least on stable? It seems it is on master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants