Skip to content

fix(settings): drop local setting for background blur filter, use provided by server #12633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jul 11, 2024
Merged

fix(settings): drop local setting for background blur filter, use provided by server #12633

nickvergessen merged 1 commit into from
Jul 11, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 3, 2024 •
edited
Loading

☑️ Resolves

Tip

To discard state, use occ user:setting <user_id> theming force_enable_blur_filter ''

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team

🛠️ API Checklist

🚧 Tasks

  • Check TInitialState change

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt feature: frontend 🖌️ "Web UI" client labels Jul 3, 2024
@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Jul 3, 2024
@Antreesy Antreesy self-assigned this Jul 3, 2024
nickvergessen
nickvergessen reviewed Jul 4, 2024
View reviewed changes
DorraJaouad
DorraJaouad reviewed Jul 5, 2024
View reviewed changes
@Antreesy Antreesy force-pushed the fix/7896/css-blur branch from a6e39f7 to ed39a6b Compare July 9, 2024 08:05
@Antreesy
Copy link
Contributor Author

Antreesy commented Jul 11, 2024 •
edited
Loading

Putting a backport label, as server backports are planned but not merged yet

DorraJaouad
DorraJaouad approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DorraJaouad

This comment was marked as duplicate.

Sign in to view

@nickvergessen nickvergessen merged commit 77441ac into main Jul 11, 2024
@nickvergessen nickvergessen deleted the fix/7896/css-blur branch July 11, 2024 08:31
@nickvergessen
Copy link
Member

nickvergessen commented Aug 22, 2024

Backport label is for 29?
I think server only has it in 30?

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 22, 2024

Was backported for stable29: nextcloud/server#46258

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 22, 2024

/backport to stable29

@backportbot backportbot bot mentioned this pull request Aug 22, 2024
Merged
@Antreesy Antreesy mentioned this pull request Oct 10, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client technical debt

Projects

None yet

Milestone

v20.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @nickvergessen @DorraJaouad