Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 26, 2024

Summary

  1. when scrolling the file list should not be visible behind the filters
  2. on mobile we need to remove the padding of the filters to ensure they are accessible
Bildschirmaufnahme_20240726_132643.webm

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Jul 26, 2024
@susnux susnux requested review from juliusknorr, nfebe and sorbaugh July 26, 2024 11:30
@susnux susnux requested a review from skjnldsv as a code owner July 26, 2024 11:30
@juliusknorr
Copy link
Member

Would be nice to address the cut off select input as well ;)

Also seems to happen when opening it:
Screenshot 2024-07-26 at 14 50 41

@susnux
Copy link
Contributor Author

susnux commented Jul 26, 2024

Would be nice to address the cut off select input as well ;)

Unrelated to this and seems like a component issue :)

@juliusknorr
Copy link
Member

juliusknorr commented Jul 26, 2024

I'm not sure where the of users is originating from but my screenshot has a broken entry that inspecting has "99dcbxiv" as a user id on daily which does not exist.

@susnux
Copy link
Contributor Author

susnux commented Jul 26, 2024

I'm not sure where the of users is originating

@juliushaertl two sources:

  1. owner property of the node
  2. sharee of the node

I think there might be a problem if 2 is a group(?) I will investigate this.

1. when scrolling the file list should not be visible behind the filters
2. on mobile we need to remove the padding of the filters to ensure they are accessible

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/file-filters-design branch from 29abef8 to 7abaee8 Compare July 26, 2024 13:27
@susnux
Copy link
Contributor Author

susnux commented Jul 26, 2024

/compile

Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 7eacd8b into master Jul 26, 2024
@susnux susnux deleted the fix/file-filters-design branch July 26, 2024 14:02
@blizzz blizzz mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File filter has no background when sticky during scroll

5 participants