-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(activity): add share link upload notifications #46945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9273054 to
07615bc
Compare
3938052 to
80231e6
Compare
c381c15 to
bb79a17
Compare
yemkareems
approved these changes
Aug 7, 2024
bb79a17 to
8ab0484
Compare
Altahrim
approved these changes
Aug 7, 2024
Signed-off-by: skjnldsv <[email protected]>
8ab0484 to
3cb8062
Compare
Merged
8 tasks
nfebe
added a commit
that referenced
this pull request
Jun 4, 2025
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users. This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails. Related: #46945 Signed-off-by: nfebe <[email protected]>
nfebe
added a commit
that referenced
this pull request
Jun 17, 2025
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users. This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails. Related: #46945 Signed-off-by: nfebe <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users. This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails. Related: #46945 Signed-off-by: nfebe <[email protected]>
AIlkiv
pushed a commit
to AIlkiv/server
that referenced
this pull request
Jul 10, 2025
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users. This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails. Related: nextcloud#46945 Signed-off-by: nfebe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
feature: activity and notification
feature: sharing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45449
Needs nextcloud/activity#1745