fix: Set public link upload email notification to opt-in #53322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GretaD
approved these changes
Jun 16, 2025
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users. This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails. Related: #46945 Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/public-upload-notification-default
branch
from
cebbbfc to
1f8a230
Compare
susnux
approved these changes
Jun 17, 2025
AndyScherzinger
approved these changes
Jun 17, 2025
Contributor
Author
|
backport to stable31 |
Contributor
Author
|
/backport to stable31 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now sets
isDefaultEnabledto false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users.This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails.
Related: #46945