fix(dav): Ensure share properties are also set on public remote endpoint #46987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
skjnldsv
approved these changes
Aug 2, 2024
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
This is on the very edge between a fix and a feat... 😅🙈
Approved nonetheless!
Merged
come-nc
reviewed
Aug 5, 2024
Merged
AndyScherzinger
force-pushed
the
fix/dav-public
branch
from
9848f19 to
162f9b0
Compare
| * Convert target path to source path and pass the function call to the correct storage provider | ||
| */ | ||
| class SharedStorage extends \OC\Files\Storage\Wrapper\Jail implements ISharedStorage, IDisableEncryptionStorage { | ||
| class SharedStorage extends \OC\Files\Storage\Wrapper\Jail implements LegacyISharedStorage, ISharedStorage, IDisableEncryptionStorage { |
Check notice
Code scanning / Psalm
DeprecatedInterface
Signed-off-by: Ferdinand Thiessen <[email protected]>
miaulalala
approved these changes
Aug 12, 2024
| }); | ||
|
|
||
| $propFind->handle(self::DATA_FINGERPRINT_PROPERTYNAME, function () use ($node) { | ||
| $propFind->handle(self::DATA_FINGERPRINT_PROPERTYNAME, function () { |
Check notice
Code scanning / Psalm
MissingClosureReturnType
| use OCP\Files\Storage\ISharedStorage; | ||
| use OCP\Share\IShare; | ||
|
|
||
| class PublicShareWrapper extends Wrapper implements ISharedStorage { |
Check notice
Code scanning / Psalm
DeprecatedInterface
Signed-off-by: Ferdinand Thiessen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that public and internal endpoint both provide the necessary data, so we can e.g. on both request
nc:note.As the share note is not something only for users but also for public shares.
Checklist