Skip to content

[stable30] fix(css): Adjust header styles to only add focus-visible styles to menu #47641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Sep 2, 2024
Merged

[stable30] fix(css): Adjust header styles to only add focus-visible styles to menu #47641

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
282af4c
fix(css): Adjust header styles to only add focus-visible styles to menu
susnux Aug 29, 2024
5351a7a
chore(assets): Recompile assets
nextcloud-command Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(css): Adjust header styles to only add focus-visible styles to menu 
Only the main menu should be styles by the header styles, not the popover menus.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Aug 30, 2024
commit 282af4c89cfd04ad4eda42c64000293c0f7e9235
33 changes: 17 additions & 16 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,25 @@
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
a:not(.button):focus-visible, button:not(.button-vue):focus-visible, div[role="button"]:focus-visible {
outline: none;
}
user-select: none;

a:not(.button):focus-visible::after, .button-vue:focus-visible::after, div[role=button]:focus-visible::after {
content: " ";
position: absolute;
transform: translateX(-50%);
width: 12px;
height: 2px;
border-radius: 3px;
background-color: var(--color-background-plain-text);
left: 50%;
opacity: 1;
}
#nextcloud:focus-visible,
.app-menu-entry a:focus-visible,
.header-menu button:first-of-type:focus-visible {
outline: none;

a:not(.button):focus-visible::after, .button-vue:focus-visible::after {
bottom: 2px;
&::after {
content: " ";
position: absolute;
inset-block-end: 2px;
transform: translateX(-50%);
width: 12px;
height: 2px;
border-radius: 3px;
background-color: var(--color-background-plain-text);
inset-inline-start: 50%;
opacity: 1;
}
}

.header-right {
Expand Down