feat: Make CheckServerResponseTrait public and provide as OCP\SetupCheck\CheckServerResponseTrait
#47947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
approved these changes
Sep 13, 2024
Contributor
Author
|
BTW alternative I considered: Making this an abstract class to make class properties more clear. I think a Trait is best fit here. |
nickvergessen
approved these changes
Sep 16, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
- But please lets merge #48063 first as it needs a backport to 30
Member
|
…pCheck\CheckServerResponseTrait` This trait is used by other apps for creating setup checks, so we should provide it instead apps using private API. Signed-off-by: Ferdinand Thiessen <[email protected]>
nickvergessen
force-pushed
the
feat/make-setup-check-trait-public
branch
from
8da2887 to
7fbd518
Compare
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This trait is used by other apps for creating setup checks, so we should provide it instead apps using private API.
Note that I removed the
runHeadas this is just sugar but having it in OCP could make things in the future harder...Checklist