Skip to content

fix(SetupChecks): Make sure array key is set #49373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
solracsf merged 1 commit into from
Nov 21, 2024
Merged

fix(SetupChecks): Make sure array key is set #49373

solracsf merged 1 commit into from
Nov 21, 2024

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Nov 19, 2024 •
edited
Loading

Summary

Backporting a portion of #47947 to fix an error. This targets stable30 on purpose.

Checklist

@solracsf solracsf added bug 3. to review Waiting for reviews labels Nov 19, 2024
@solracsf solracsf added this to the Nextcloud 30.0.3 milestone Nov 19, 2024
@solracsf solracsf requested a review from susnux November 19, 2024 13:06
@solracsf
Copy link
Member Author

solracsf commented Nov 19, 2024

/backport to stable29

@solracsf
Copy link
Member Author

solracsf commented Nov 19, 2024

/backport to stable28

@solracsf solracsf changed the title [stable30] fix(SetupShecks): Make sure array key is set [stable30] fix(SetupChecks): Make sure array key is set Nov 19, 2024
@solracsf solracsf force-pushed the backportArrayKeySetupCheks branch from fdc6c83 to 50d071e Compare November 19, 2024 13:11
@solracsf solracsf changed the title [stable30] fix(SetupChecks): Make sure array key is set fix(SetupChecks): Make sure array key is set Nov 19, 2024
@solracsf solracsf linked an issue Nov 19, 2024 that may be closed by this pull request
Better error message when configured hostnames/URLs are invalid (versus Trying to access array offset on value of type bool) #49370
Closed
8 tasks
joshtrichards
joshtrichards approved these changes Nov 19, 2024
View reviewed changes
@joshtrichards joshtrichards mentioned this pull request Nov 19, 2024
Open
5 tasks
@solracsf
Copy link
Member Author

solracsf commented Nov 19, 2024

Should we wait for #49379 ?

@solracsf
Copy link
Member Author

solracsf commented Nov 21, 2024

Merging here, let's having the new PR backported where applicable.

@solracsf solracsf merged commit 09ad395 into stable30 Nov 21, 2024
171 checks passed
@solracsf solracsf deleted the backportArrayKeySetupCheks branch November 21, 2024 12:08
@solracsf
Copy link
Member Author

solracsf commented Nov 21, 2024

/backport to stable29

@backportbot

This comment was marked as resolved.

Sign in to view
@solracsf solracsf mentioned this pull request Nov 21, 2024
Closed
8 tasks
@backportbot backportbot bot mentioned this pull request Nov 21, 2024
Merged
@backportbot

This comment was marked as resolved.

Sign in to view
@backportbot

This comment was marked as resolved.

Sign in to view
@backportbot

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes

@come-nc come-nc come-nc approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request bug

Projects

None yet

Milestone

Nextcloud 30.0.3

Development

Successfully merging this pull request may close these issues.

Better error message when configured hostnames/URLs are invalid (versus Trying to access array offset on value of type bool)

4 participants

@solracsf @joshtrichards @come-nc