fix: Move storage constructor to specific interface #48111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
come-nc
force-pushed
the
fix/move-storage-constructor-to-specific-interface
branch
2 times, most recently
from
1fb60c1 to
d17f5e8
Compare
come-nc
added
the
pending documentation
icewind1991
approved these changes
Sep 17, 2024
come-nc
requested review from
a team,
Altahrim,
ArtificialOwl,
nfebe and
susnux
and removed request for
a team
That allows Wrappers to use DI and not care about the constructor Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/move-storage-constructor-to-specific-interface
branch
from
d17f5e8 to
94b0a0e
Compare
…r parameter Co-authored-by: Kate <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
deleted the
fix/move-storage-constructor-to-specific-interface
branch
4 tasks
Merged
come-nc
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
That allows Wrappers to use DI and not care about the constructor
Checklist