Skip to content

Conversation

@provokateurin
Copy link
Member

Summary

I noticed that if (!$this->storage->file_exists($this->internalPath)) { was called with null as $internalPath which is not allowed.
Added strong types and fixed the tests which were giving wrong/incomplete inputs.

Checklist

@provokateurin provokateurin added 3. to review Waiting for reviews technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Oct 1, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 1, 2024
@provokateurin
Copy link
Member Author

Wrapper\Encryption has similar troubles, gonna fix that as well.

@provokateurin provokateurin marked this pull request as draft October 1, 2024 13:18
@provokateurin provokateurin marked this pull request as ready for review October 1, 2024 13:57
@provokateurin provokateurin changed the title refactor(Stream\Encryption): Migrate to strong types refactor(Encryption): Migrate to strong types Oct 1, 2024
@provokateurin provokateurin force-pushed the refactor/stream-encryption/typings branch from 9b32a61 to 73ca69d Compare October 1, 2024 15:58
@provokateurin provokateurin requested a review from come-nc October 7, 2024 08:14
@provokateurin provokateurin force-pushed the refactor/stream-encryption/typings branch from 73ca69d to 8aceb68 Compare October 7, 2024 12:02
@provokateurin provokateurin force-pushed the refactor/stream-encryption/typings branch from 8aceb68 to 4412b2b Compare October 7, 2024 12:12
@provokateurin provokateurin merged commit 4144309 into master Oct 7, 2024
@provokateurin provokateurin deleted the refactor/stream-encryption/typings branch October 7, 2024 12:37
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants